Conversation
|
/compile / |
abdc077 to
a83bf64
Compare
|
/compile / |
c54f88e to
6d431c8
Compare
|
/compile amend / |
|
thanks for looking into this! |
6d431c8 to
2432df5
Compare
|
/compile amend / |
2432df5 to
ca91803
Compare
ca91803 to
a922b12
Compare
|
/compile amend / |
a922b12 to
150441c
Compare
|
|
||
| #imgframe img { | ||
| max-height: 100% !important; | ||
| max-height: calc(100vh - var(--header-height) - #{$footer-height} - #{$download-button-section-height}) !important; |
There was a problem hiding this comment.
Do you have better ideas? Other solutions didnt work in my testing...
| } | ||
|
|
||
| #imgframe video { | ||
| max-height: calc(100vh - var(--header-height) - #{$footer-height} - #{$download-button-section-height}); |
There was a problem hiding this comment.
Is it still relevant?
Considering we're using the viewer now to render single files shares?
There was a problem hiding this comment.
Yes, this was needed to make it work with any screen size...
There was a problem hiding this comment.
SHould it not be handled widely then? Make the viewer container takign the full size?
Not just video or img tags
There was a problem hiding this comment.
I didn't find other formats that would need fixing so only applied it to these.
There was a problem hiding this comment.
Btw: public audio playback is currently broken IIRC: #34027
There was a problem hiding this comment.
I'm working on a separate PR for audio playback here #34051 - would style that after this is merged.
Signed-off-by: szaimen <szaimen@e.mail.de>
150441c to
b664644
Compare
|
/compile amend / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
b664644 to
335964d
Compare
|
CI failure unrelated |
Close #33858
Close #33803
Signed-off-by: szaimen szaimen@e.mail.de