Fix apps list issues caused by redesign#33939
Merged
CarlSchwan merged 1 commit intomasterfrom Sep 8, 2022
Merged
Conversation
Member
|
Not convinced by the choices of colours
|
skjnldsv
approved these changes
Sep 7, 2022
Member
skjnldsv
left a comment
There was a problem hiding this comment.
Other than the comment, good 👍
Member
Author
Fine by me, I'll change that 👍 |
Member
|
@skjnldsv good point, I would even go with just text-only for "Remove". Otherwise we have red buttons all over. |
Merged
- Make icons work on dark theme - Use new buttons - Fix some eslint warnings Signed-off-by: Carl Schwan <carl@carlschwan.eu>
a6b4c82 to
3fa59ba
Compare
Member
Author
|
New screenshot with the suggestions from Jan and 'John'
|
nimishavijay
approved these changes
Sep 8, 2022
jancborchardt
approved these changes
Sep 8, 2022
Member
jancborchardt
left a comment
There was a problem hiding this comment.
Looks much much nicer and less scary, great work! :)
Member
Author
|
Ci failure unrelated (sharing acceptance tests) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #33926
Close #33861