Skip to content

Fix creation of new user and display the correct error message#33625

Merged
PVince81 merged 1 commit intomasterfrom
fix/33572/add-user
Sep 1, 2022
Merged

Fix creation of new user and display the correct error message#33625
PVince81 merged 1 commit intomasterfrom
fix/33572/add-user

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Aug 19, 2022 •
edited
Loading

Fix #33572

  • Fix creation of new user (either with the same or different values entered for Username and Display name)
  • Rollback user creation on invalid displayname
  • Display the correct error message

Out-of-scope

Rollback user creation on other exceptions

@Pytal Pytal added this to the Nextcloud 25 milestone Aug 19, 2022
@Pytal Pytal self-assigned this Aug 19, 2022
@Pytal Pytal mentioned this pull request Aug 19, 2022
Closed
9 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 19, 2022
View reviewed changes
PVince81
PVince81 approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kesselb
kesselb reviewed Aug 22, 2022
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The problem itself is present on 24 and 23 too. I guess it's kinda hard to backport the api changes. However the issue only occurs when userId = displayName so the impact is hopefully not to big.

@Pytal Pytal force-pushed the fix/33572/add-user branch from c300eb2 to 85b1909 Compare August 22, 2022 19:13
@Pytal
Fix creation of new user and display the correct error message
d595859 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/33572/add-user branch from 85b1909 to d595859 Compare August 22, 2022 19:13
This was referenced Aug 24, 2022
Merged
Merged
@kesselb kesselb mentioned this pull request Aug 31, 2022
Closed
9 tasks
@PVince81 PVince81 merged commit 253c064 into master Sep 1, 2022
@PVince81 PVince81 deleted the fix/33572/add-user branch September 1, 2022 15:07
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 1, 2022
@ArtificialOwl
Copy link
Member

ArtificialOwl commented Sep 2, 2022 •
edited
Loading

👍

@ArtificialOwl
Copy link
Member

ArtificialOwl commented Sep 29, 2022

should we backport this one to stable24 ?

@Pytal
Copy link
Member Author

Pytal commented Sep 29, 2022

We don't backport public API changes though?

@GretaD GretaD mentioned this pull request Nov 7, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb left review comments

@PVince81 PVince81 PVince81 approved these changes

@come-nc come-nc come-nc approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@Pytal Pytal

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: settings feature: users and groups regression

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

[Bug]: Creating new (database) user show misleading error message and loses data

5 participants

@Pytal @ArtificialOwl @PVince81 @kesselb @come-nc