Fix label for allow download share permission#33448
Merged
juliusknorr merged 1 commit intomasterfrom Aug 4, 2022
Merged
Conversation
1 task
Member
Author
|
@CarlSchwan Probably can be cherry-picked directly to #33416 |
Member
Author
|
/rebase |
45f6694 to
10f1e49
Compare
Member
Author
|
/compile amend / |
Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
10f1e49 to
02fd7d2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I missed parts of the discussion on this, but couldn't see anything in the original PR.
The permission flag will allow or deny download on any filetype, therefore it doesn't make sense to limit the label to office files for shared folders.