Identify the login page explicitly by the page title#33281
Merged
Conversation
96a9db5 to
7d66246
Compare
szaimen
reviewed
Jul 19, 2022
Member
Author
|
Going with "Login – Nextcloud" |
szaimen
reviewed
Jul 20, 2022
7d66246 to
cfc24f5
Compare
Contributor
|
Possible performance regression detected Show Output |
Member
|
I feel like this shoukd be done in the backend instead by just passinf a title to the template arguments |
Member
|
That reminds me i need to revisit #29881 |
Member
The guests template does not support this yet: but yeah something like |
Signed-off-by: Christopher Ng <chrng8@gmail.com>
cfc24f5 to
92500e8
Compare
Member
Author
|
@CarlSchwan @nickvergessen what do you think now? |
CarlSchwan
approved these changes
Jul 21, 2022
nickvergessen
approved these changes
Jul 21, 2022
Member
|
@PVince81 CI was positively failing |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default the page title would be "Login - Nextcloud"