Use hover css variable for primary buttons#33267
Merged
juliusknorr merged 1 commit intomasterfrom Jul 19, 2022
Merged
Conversation
Member
Author
|
Edit: Nevermind just found that the button component uses the main text color then. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
4440235 to
9e0d6f5
Compare
marcoambrosini
approved these changes
Jul 18, 2022
Pytal
approved these changes
Jul 18, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix some buttons becoming to bright on hover/focus when using the server styles and add a missing focus border.
Couldn't find a button quickly but setting one of the firstrunwizard buttons to primary for comparison (on focus):
Before:

After:
