Add skip content buttons to the public page layout#33266
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
nickvergessen
approved these changes
Jul 18, 2022
Member
nickvergessen
left a comment
There was a problem hiding this comment.
layout.geusts.php is the login/eror page, right? Then this is fine
Member
Author
Yes, and layout.base.php doesn't have any content. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the skip to navigation/content buttons to public pages as well. For the other layouts it didn't seem to be that useful as there is no navigation with apps or additional buttons in the right header section that are necessary to be skippable.
Follow up to #33247
For public pages the app-navigation skip button is disabled by default as it is more likely that there is none with non-vue apps like for files_sharing and public share links.