Do not redirect if requested font, style or script can not be found#33174
Merged
Do not redirect if requested font, style or script can not be found#33174
Conversation
Contributor
|
Possible performance regression detected Show Output |
Contributor
|
Possible performance regression detected Show Output |
Pytal
approved these changes
Jul 8, 2022
come-nc
approved these changes
Jul 11, 2022
Member
|
@ChristophWurst please cleanup the commit history |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
f838d20 to
a1149b0
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a page in Nextcloud requests a font, stylesheet or script that doesn't exist we currently redirect to the default page. This comes with the following consequences
The stylesheet https://localhost/apps/dashboard/ was not loaded because its MIME type, “text/html”, is not “text/css”.User routing is not affected by this. If you navigate to
<domain>/apps/phpmymailappNextcloud still redirects to the default page. That behavior is desired.Tested with FF and Chromium.
Ref https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-Fetch-Dest