Closed
Conversation
Signed-off-by: Louis Chemineau <louis@chmn.me>
Contributor
Author
|
/backport to stable24 |
This was referenced Jun 7, 2022
CarlSchwan
requested changes
Jun 7, 2022
Member
CarlSchwan
left a comment
There was a problem hiding this comment.
Not a fan of this, the api was added in 25 and an app that wants to use that should target 25. We can't specify in an appinfo.xml that an app is only available for 24.0.1
Member
#9024 😈 |
Member
|
imo it is sufficient to have this only in the stable branch. otherwise, you won't not know what the proper version are in 23 and 24 if only the version of 22 remains. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods will be backported to 23 and 22 but PR are still pending. I'll create a new PR to update the
@sincewhen they get merged.