Skip to content

Update core to PHP 7.4 standard#31948

Merged
CarlSchwan merged 1 commit intomasterfrom
core-cleanup-74
May 30, 2022
Merged

Update core to PHP 7.4 standard#31948
CarlSchwan merged 1 commit intomasterfrom
core-cleanup-74

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Apr 12, 2022

  • Typed properties
  • Port to LoggerInterface

Signed-off-by: Carl Schwan carl@carlschwan.eu

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Apr 12, 2022
@CarlSchwan CarlSchwan requested review from a team and come-nc April 12, 2022 15:57
@CarlSchwan CarlSchwan self-assigned this Apr 12, 2022
@CarlSchwan CarlSchwan requested review from blizzz and juliusknorr and removed request for a team April 12, 2022 15:57
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Apr 12, 2022
@CarlSchwan CarlSchwan force-pushed the core-cleanup-74 branch 3 times, most recently from eed82c5 to 55a4fa2 Compare April 12, 2022 16:23
artonge
artonge reviewed Apr 12, 2022
View reviewed changes
@CarlSchwan
Copy link
Member Author

CarlSchwan commented Apr 13, 2022

found some issues, don't merge

blizzz
blizzz requested changes Apr 13, 2022
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd. #31948 (comment)

@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 13, 2022
@CarlSchwan CarlSchwan mentioned this pull request Apr 25, 2022
Closed
24 tasks
come-nc
come-nc reviewed May 5, 2022
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and fix or explain the issues

@CarlSchwan CarlSchwan force-pushed the core-cleanup-74 branch 2 times, most recently from 4e7cb13 to ea926ef Compare May 6, 2022 13:50
@CarlSchwan CarlSchwan requested review from blizzz and come-nc May 6, 2022 13:50
@CarlSchwan
Copy link
Member Author

CarlSchwan commented May 6, 2022

found some issues, don't merge

Fixed the issues found last time and all the unit tests now pass (needed to change from ILogger to LoggerInterface there too)

come-nc
come-nc requested changes May 9, 2022
View reviewed changes
@CarlSchwan
Update core to PHP 7.4 standard
b70c6a1 
- Typed properties
- Port to LoggerInterface

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan requested a review from kesselb May 20, 2022 20:18
@come-nc
Copy link
Contributor

come-nc commented May 24, 2022

@artonge @blizzz Should be good for merging now?

@CarlSchwan CarlSchwan merged commit 1164c76 into master May 30, 2022
@CarlSchwan CarlSchwan deleted the core-cleanup-74 branch May 30, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@blizzz blizzz Awaiting requested review from blizzz

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@CarlSchwan CarlSchwan

Labels

2. developing Work in progress

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

4 participants

@CarlSchwan @come-nc @blizzz @artonge