Fix Error: Undefined index: redirect_url#31947
Merged
blizzz merged 1 commit intonextcloud:masterfrom Oct 6, 2022
AndyXheli:patch-1
Merged
Fix Error: Undefined index: redirect_url#31947blizzz merged 1 commit intonextcloud:masterfrom AndyXheli:patch-1
blizzz merged 1 commit intonextcloud:masterfrom
AndyXheli:patch-1
Conversation
Signed-off-by: Andy Xheli <axheli@axtsolutions.com> Should fix Undefined index: redirect_url at core/templates/twofactorsetupselection.php #21968
CarlSchwan
approved these changes
Apr 12, 2022
Member
CarlSchwan
left a comment
There was a problem hiding this comment.
Thanks!
Looking at core/Controller/TwoFactorChallengeController.php::setupProviders, we indeed don't provide this variable
Contributor
Author
|
@szaimen Can we also backport once approved to NC 23 ? |
Member
|
Would be better to restore the value so when you clicked on a link and need to authenticate, you do end up at the first link again? |
Merged
miaulalala
approved these changes
Apr 14, 2022
Merged
Contributor
Author
|
@blizzz any way we can get this in NC 25 and backport this to NC 24 please ? Still getting this message anytime a user setups 2fa for the first time
|
Member
|
/backport to stable25 |
Member
|
/backport to stable24 |
This was referenced Oct 6, 2022
Contributor
|
Would be nice to have this in version 23 as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Xheli axheli@axtsolutions.com
Should fix Undefined index: redirect_url at core/templates/twofactorsetupselection.php #21968
#21968 (comment)