Principal search by display name case insensitive#31886
Merged
Conversation
Adjust principal search to be case insensitive even with exact match. This aligns the behavior to how the search also works in Collaborators/UserPlugin Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Contributor
|
Nice, this also brings us more into line with RFC3774;
|
miaulalala
approved these changes
Apr 8, 2022
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
nickvergessen
approved these changes
Apr 8, 2022
Merged
This was referenced Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust principal search to be case insensitive even with exact match.
This aligns the behavior to how the search also works in
Collaborators/UserPlugin
This aligns the behavior with https://github.com/nextcloud/server/blob/bugfix/noid/principal-search-case-insensitive-dn/lib/private/Collaboration/Collaborators/UserPlugin.php#L180
To test:
Before the fix: no results
After the fix: one result found