Fix assignment of the LDAP Wizard connection#31779
Merged
Conversation
Signed-off-by: Christoph Wurst <[email protected]>
come-nc
approved these changes
Mar 31, 2022
Contributor
|
We have this in other places too: |
Member
Author
|
If you access a property by its name then it's fine. But our $cr isn't a string and the wrong syntax requires one, forcing the serialization of the object. |
Contributor
okay |
CarlSchwan
approved these changes
Mar 31, 2022
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
This was referenced Apr 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP<8.1 allowed this and serialized the connection object into a string. That means the connection wasn't actually remembered,
$this->crwould still be null after the assignment of$this->$cr.