Skip to content

Comments

Emojihelper interface#31703

Merged
nickvergessen merged 2 commits intomasterfrom
techdebt/noid/emojihelper-interface
Apr 29, 2022
Merged

Emojihelper interface#31703
nickvergessen merged 2 commits intomasterfrom
techdebt/noid/emojihelper-interface

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 24, 2022 •
edited
Loading

@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Mar 24, 2022
@nickvergessen nickvergessen mentioned this pull request Mar 24, 2022
Closed
@nickvergessen nickvergessen force-pushed the techdebt/noid/emojihelper-interface branch 2 times, most recently from 6ce8ae4 to 320f0a7 Compare March 25, 2022 11:40
@vitormattos vitormattos mentioned this pull request Mar 30, 2022
Closed
@nickvergessen nickvergessen force-pushed the techdebt/noid/emojihelper-interface branch 3 times, most recently from 6236991 to 0059c1b Compare April 4, 2022 11:44
@nickvergessen nickvergessen requested review from a team, CarlSchwan, PVince81, danxuliu, juliusknorr and vitormattos and removed request for a team April 28, 2022 07:59
@CarlSchwan
Copy link
Member

CarlSchwan commented Apr 28, 2022

Ihmo only 25

@nickvergessen
Copy link
Member Author

nickvergessen commented Apr 28, 2022

Yeah pull request is some long time old :D

@vitormattos vitormattos mentioned this pull request Apr 28, 2022
Closed
nickvergessen and others added 2 commits April 28, 2022 07:09
@nickvergessen @vitormattos
Extract the EmojiService from user status and add an OCP interface
902476f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@vitormattos
Increase check if support reactions
a75a22f 
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos vitormattos force-pushed the techdebt/noid/emojihelper-interface branch from 0059c1b to 68a529a Compare April 28, 2022 11:01
@vitormattos vitormattos requested a review from CarlSchwan April 28, 2022 11:09
@vitormattos vitormattos force-pushed the techdebt/noid/emojihelper-interface branch from 8fd169b to a75a22f Compare April 28, 2022 11:25
@vitormattos
Copy link

vitormattos commented Apr 28, 2022

Reverted the last commits to maintain this PR only to add the interface.
The last commits will be moved to a separated PR.

@nickvergessen nickvergessen merged commit 0d87335 into master Apr 29, 2022
@nickvergessen nickvergessen deleted the techdebt/noid/emojihelper-interface branch April 29, 2022 16:31
@vitormattos vitormattos mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

@PVince81 PVince81 Awaiting requested review from PVince81

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

+1 more reviewer

@vitormattos vitormattos vitormattos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: comments feature: status technical debt

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @CarlSchwan @vitormattos @juliusknorr