Validate overwrite.cli.url to be a url in setup check#31430
Conversation
dec1fec to
141177c
Compare
141177c to
225cc2e
Compare
|
/backport to stable23 |
|
/backport to stable22 |
nickvergessen
left a comment
There was a problem hiding this comment.
Can you state what the improvement is?
From reading the code the improvement is that you can now have false positives for a warning?
overwrite.cli.url to be a url in setup check
e0d48e9 to
1947ed3
Compare
Signed-off-by: szaimen <szaimen@e.mail.de>
e58122e to
4191a17
Compare
| $suggestedOverwriteCliUrl = $this->request->getServerProtocol() . '://' . $this->request->getInsecureServerHost() . \OC::$WEBROOT; | ||
|
|
||
| // Check correctness by checking if it is a valid URL | ||
| if (filter_var($currentOverwriteCliUrl, FILTER_VALIDATE_URL)) { |
There was a problem hiding this comment.
Is everyone, especially @juliushaertl fine if we do it like this for now?
After merging, I will rebase Carls PR and change it there to use his validation logic but since I want to backport this we will not have the validation logic in place.
For me the most important change of this PR is to make admins aware of this config which the PR does. Since the warning is only shown in the admin panel, it is in my opinion no big problem if it is sometimes false-positive because of this unperfect filter and will not cause any harm.
|
Thanks everyone! Merging then :) |
|
/backport to stable23 |
|
/backport to stable22 |
Close #31429
Signed-off-by: szaimen szaimen@e.mail.de