Fix #31303: Make reminder notification behaviour selectable..#31337
Conversation
b065cb0 to
8e5d394
Compare
|
Maybe we can add left-padding to this element to make it clear it belongs to the same group as above, like in the sharing admin settings? |
27a0913 to
e96c9f7
Compare
Requested changes are made. |
| class="checkbox" | ||
| :disabled="!sendEventReminders"> | ||
| <label for="caldavSendEventRemindersToSharedGroupMembers"> | ||
| {{ $t('dav', 'Send reminder notifications not to shared group members.') }} |
There was a problem hiding this comment.
Might not be group shares but direct user-shares too.
There was a problem hiding this comment.
How would you phrase this?
There was a problem hiding this comment.
Send notifications to all shared users of an event and not only to the organizer and attendees. ?
There was a problem hiding this comment.
Something like Send notifications to calendar sharees as well.
There was a problem hiding this comment.
Send notifications to calendar sharees as well as to the organizer and attendees. ?
There was a problem hiding this comment.
We can move the second part of the sentence above, something like : reminders are always sent to organizers and attendees.
There was a problem hiding this comment.
Like this? (Without the dot after well)
There was a problem hiding this comment.
Uh, should it be reminder notification instead of plain notification?
c853af9 to
cfe58dc
Compare
8ed0994 to
27f5a0d
Compare
86520f6 to
34f3022
Compare
|
@tcitworld, @miaulalala, @ChristophWurst I've had some problems with CI but think this PR is ready for another review now. |
34f3022 to
92aa0e2
Compare
|
Hey @tcitworld, Changes are done. Can you review again? ^^ |
tcitworld
left a comment
There was a problem hiding this comment.
Just needs to test that the failing test is not a flaky one but LGTM overall.
92aa0e2 to
2bca603
Compare
c256554 to
08e2f37
Compare
Signed-off-by: Daniel Teichmann <daniel.teichmann@das-netzwerkteam.de>
…tting. Signed-off-by: Daniel Teichmann <daniel.teichmann@das-netzwerkteam.de>
08e2f37 to
f414882
Compare
All checks pass now: LGTM? ^^ |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Fixes #31303 and nextcloud/calendar#3946.
I'm open for your opinions. ^^
And please check my spelling, I'm not native. :D