[stable22] Fix preview generation for office documents#30971
Merged
CarlSchwan merged 1 commit intostable22from Feb 2, 2022
Merged
[stable22] Fix preview generation for office documents#30971CarlSchwan merged 1 commit intostable22from
CarlSchwan merged 1 commit intostable22from
Conversation
`new \imagick()` returns an object, but we need the image blob (binary string) from this object. This is a partial backport of #26531, which brings a lot of refactoring but also contains the fix. Fixes: #29956 Signed-off-by: Jonas Meurer <[email protected]>
CarlSchwan
approved these changes
Feb 2, 2022
Member
Author
|
The drone CI failures are unrelated. Samba always fails on stable22, integration-transfer-ownership-features seems like a timeout. |
szaimen
approved these changes
Feb 2, 2022
Contributor
szaimen
left a comment
There was a problem hiding this comment.
Fine by me if it works :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new \imagick()returns an object, but we need the image blob (binarystring) from this object.
This is a partial backport of #26531, which brings a lot of refactoring
but also contains the fix.
Fixes: #29956
Signed-off-by: Jonas Meurer [email protected]