Closed
Conversation
ChristophWurst
requested changes
Jan 27, 2022
| * will handle the implementation of an export operation | ||
| * | ||
| * @param string $operationClass | ||
| * @psalm-param class-string<\OCA\UserMigration\Export\IExportOperation> $operationClass |
Member
There was a problem hiding this comment.
All constructs in OCP must only use other things from OCP. You'll have to move IExportOperation into OCP. After all you make it part of the public API that will be implemented by apps.
8550c8d to
a312fcc
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
a312fcc to
ef09619
Compare
Member
Author
|
Superseded by #30901 for complete migration including export and import |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on nextcloud/user_migration#11