Skip to content

improve personal settings on mobile#30364

Merged
skjnldsv merged 1 commit intomasterfrom
enh/noid/improve-personal-settings-mobile
Dec 27, 2021
Merged

improve personal settings on mobile#30364
skjnldsv merged 1 commit intomasterfrom
enh/noid/improve-personal-settings-mobile

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Dec 21, 2021 •
edited
Loading

Before After
192 168 146 128_8443_index php_settings_user(Moto G4) (1) 192 168 146 128_8443_index php_settings_user(Moto G4)

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e SERVER_BRANCH=enh/noid/improve-personal-settings-mobile \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added enhancement 2. developing Work in progress feature: settings feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Dec 21, 2021
@szaimen szaimen added this to the Nextcloud 24 milestone Dec 21, 2021
@nextcloud-command nextcloud-command force-pushed the enh/noid/improve-personal-settings-mobile branch from 085b27a to e57aed7 Compare December 21, 2021 12:31
@szaimen
Copy link
Contributor Author

szaimen commented Dec 21, 2021

Seems like Lint / php-cs check (pull_request) Failing after 1m — php-cs check is currently broken on master...

@szaimen szaimen marked this pull request as ready for review December 21, 2021 12:35
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 21, 2021
@szaimen szaimen requested review from a team, PVince81, artonge and skjnldsv and removed request for a team December 21, 2021 12:35
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 21, 2021
@szaimen szaimen force-pushed the enh/noid/improve-personal-settings-mobile branch from e57aed7 to 5169dc0 Compare December 21, 2021 12:42
@szaimen
Copy link
Contributor Author

szaimen commented Dec 21, 2021

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enh/noid/improve-personal-settings-mobile branch from 5169dc0 to 499c648 Compare December 21, 2021 13:07
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 21, 2021
@szaimen szaimen force-pushed the enh/noid/improve-personal-settings-mobile branch from 499c648 to 47c4c9b Compare December 23, 2021 10:27
@szaimen szaimen requested review from CarlSchwan and Pytal December 23, 2021 10:28
@szaimen
Copy link
Contributor Author

szaimen commented Dec 23, 2021

/compile amend /

@szaimen @nextcloud-command
improve personal settings on mobile
70feada 
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/noid/improve-personal-settings-mobile branch from 47c4c9b to 70feada Compare December 23, 2021 11:08
@skjnldsv skjnldsv merged commit e6c6555 into master Dec 27, 2021
@skjnldsv skjnldsv deleted the enh/noid/improve-personal-settings-mobile branch December 27, 2021 09:58
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 27, 2021
@szaimen
Copy link
Contributor Author

szaimen commented Dec 27, 2021

/backport to stable23

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) feature: settings

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

3 participants

@szaimen @skjnldsv @CarlSchwan