Fix security issues when copying groupfolder with advanced ACL#29362
Merged
CarlSchwan merged 1 commit intomasterfrom Oct 21, 2021
Merged
Fix security issues when copying groupfolder with advanced ACL#29362CarlSchwan merged 1 commit intomasterfrom
CarlSchwan merged 1 commit intomasterfrom
Conversation
skjnldsv
approved these changes
Oct 21, 2021
PVince81
approved these changes
Oct 21, 2021
Member
PVince81
left a comment
There was a problem hiding this comment.
👍
let's make a ticket for the proper solution also
Using advanced ACL, it is possible that an user has access to a directory but not to a subdirectory, so the copying use Common::copyFromStorage instead of Local::copyFromStorage. Fix nextcloud/groupfolders#1692 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
b5f5883 to
9408f8a
Compare
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
This was referenced Oct 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using advanced ACL, it is possible that an user has access to a
directory but not to a subdirectory, so the copying use
Common::copyFromStorage instead of Local::copyFromStorage.
We might want to create a new interface instead of using directly
OCA\GroupFolder\ACLStorageWrapper
Fix nextcloud/groupfolders#1692
Signed-off-by: Carl Schwan carl@carlschwan.eu