Do not retain VerifyUserData job when lookup server is not available#28466
Merged
Do not retain VerifyUserData job when lookup server is not available#28466
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Member
|
Good with me. Is there an option to trigger them in case it is once switched on? |
Member
Author
The only way would be to update the account data manually, but that would be the same as before as the job also gets removed after 24 retries. (~1 day) |
blizzz
approved these changes
Aug 23, 2021
tsdicloud
added a commit
to nextmcloud/server
that referenced
this pull request
Sep 14, 2021
…n users. This avoids performance degradation of user creation batches from migration. It avoid the creation of Verify jobs completels (which are not needed for oidc users anyway) See nextcloud#28466 Signed-off-by: Bernd.Rederlechner@t-systems.com <bernd.rederlechner@t-systems.com>
dokshukin
pushed a commit
to nextmcloud/server
that referenced
this pull request
Oct 18, 2021
…n users. This avoids performance degradation of user creation batches from migration. It avoid the creation of Verify jobs completels (which are not needed for oidc users anyway) See nextcloud#28466 Signed-off-by: Bernd.Rederlechner@t-systems.com <bernd.rederlechner@t-systems.com>
dokshukin
pushed a commit
to nextmcloud/server
that referenced
this pull request
Oct 18, 2021
…n users. This avoids performance degradation of user creation batches from migration. It avoid the creation of Verify jobs completels (which are not needed for oidc users anyway) See nextcloud#28466 Signed-off-by: Bernd.Rederlechner@t-systems.com <bernd.rederlechner@t-systems.com>
sgyuris
pushed a commit
to nextmcloud/server
that referenced
this pull request
Oct 20, 2021
…n users. This avoids performance degradation of user creation batches from migration. It avoid the creation of Verify jobs completels (which are not needed for oidc users anyway) See nextcloud#28466 Signed-off-by: Bernd.Rederlechner@t-systems.com <bernd.rederlechner@t-systems.com>
Member
Author
|
/backport to stable22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the lookup server is disabled there is no need to retain a VerifyUserData job since any of the 24 attempts to verify will never succeed if the server is configured like that.
This will save some unnecessary load on the cron job execution as well as making the oc_jobs table stay in lower numbers during mass user creation.