Fix svg icons disapearing in app navigation when text overflows#27936
Fix svg icons disapearing in app navigation when text overflows#27936szaimen merged 1 commit intonextcloud:masterfrom
Conversation
|
This is with a local instance and using git master (with Firefox)
On Chromium without this patch it's also working fine. |
szaimen
left a comment
There was a problem hiding this comment.
You are right. I've overlooked that this only happens with Firefox.
Tested the PR successfully with Firefox and Chromium
|
Failing drone is unrelated |
julien-nc
left a comment
There was a problem hiding this comment.
Yup, tested with Firefox 89.
I think this can be backported to stable20, stable21 and stable22 as the issue seems to be the same. I didn't try to apply this commit in those branches though.
|
@CarlSchwan do you mind signing off your commits to pass the DCO check? |
e44082a to
99e845d
Compare
The issue is caused by the icon being positionned with negative margins and the `overflow: hidden` rule when hide the icon when the text overflows. Remove positioning with negative margins. This was only happening in Firefox. This fix nextcloud#23849 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
99e845d to
d0afc49
Compare
Done :) and added |
|
Great! Thanks a lot! :) |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
|
I fear this PR has broken the files app: |
|
Damn, yes I can see it too. We couldn't see it because of the style caching... |
|
Hmm I can't reproduce with firefox but I can with chromium. On it |
|
I can reproduce with both FF and Chromium. Did you try to reload without using the cache (just in case: CTRL+F5)? |
|
I created a patch that hopefully fix the issue (it does for me): https://github.com/nextcloud/server/pull/27973/files |
See #27936 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
See #27936 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
See #27936 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
See #27936 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
The issue is caused by the icon being positionned with negative margins
and the
overflow: hiddenrule when hide the icon when the textoverflows. Remove positioning with negative margins.
This fix #23849
Closes #24378