Change reviewers of Psalm baseline update

[MorrisJobke]

Change reviewers from Roeland and Me to Julius and Louis

I hope that's okay @juliushaertl and @artonge?

Those are the PRs like #27517 that just need a +1 and a check that the Psalm run works.

[artonge]

I guess I won't be the best to understand the changes, but I won't mind the noise and trying ^^.

[MorrisJobke]

I guess I won't be the best to understand the changes, but I won't mind the noise and trying ^^.

The Psalm baseline is basically a list of things that aren't fine from Psalms perspective but that we accepted as "works as of now". It only removes entries. So this means, when type hints, suspicious calls with wrong types, potential bugs due to wrong return types and such stuff that is detected by the static code analysis of Psalm is fixed, then those will be removed by the PR. That just makes sure, that fixed things are not reintroduced later again (without noticing).

Does that make it clear what it does?

Ah: Maybe also a little explanation of Psalm is helpful: it is a tool that does static code analysis to detect potential bugs due to wrongly handled data for example. If a variable from a code flow perspective can be int and bool, but the method expects an int, that is usually fine for PHP because it automatically casts. Nevertheless it is seen as unwanted or at least unclear behaviour. In that regard Psalm helps to find those things. Same with not available methods on interfaces but on implementations where the type hint only refers to the interface and such stuff. Full details can be found at https://psalm.dev/

[artonge]

Ok, thanks for the explanations and context. Much clearer now ! 😄