Add regex to match Windows 10 calendar user-agent#27488
Merged
juliusknorr merged 1 commit intonextcloud:masterfrom Jun 29, 2021
Merged
Add regex to match Windows 10 calendar user-agent#27488juliusknorr merged 1 commit intonextcloud:masterfrom
juliusknorr merged 1 commit intonextcloud:masterfrom
Conversation
Member
|
Plugin::ENABLE_FOR_CLIENTSSee the test failure https://drone.nextcloud.com/nextcloud/server/6224/9/4 |
Member
|
@msrn Please run |
tcitworld
approved these changes
Jun 21, 2021
Contributor
Author
|
Do I need to squash this to a single commit? |
Member
It's usually preferred, yes :) |
* Match first part of the Windows 10 calendar user-agent * Exposes subscribed calendars for Windows 10 calendar * Update unit test Signed-off-by: Mikael Saarinen <mikaels@iki.fi>
Contributor
Author
Squashed, and rebased to master aswell |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds Windows 10 calendar to the list of user-agents in WebCalCaching -plugin, and exposes subscribed calendars to Windows 10 calendar client.
Typical user-agent string for Windows 10 Calendar is:
MSFT-WIN-3/10.0.19041Included regex matches, the
MSFT-WIN-3part only.Considers #17754
@tcitworld