Move exception logging to separate field#27451
Merged
MorrisJobke merged 1 commit intomasterfrom Jun 10, 2021
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Member
Author
|
Do we have any place to mention noticable changes for admins in the changelog for example? Maybe something for @jospoortvliet ? |
Member
Author
|
Documentation pr in nextcloud/documentation#6764 |
Member
|
Member
Author
|
Ah also about admins, ok then I'll add to that. |
This was referenced Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to adjust the log format when exceptions are logged to move them to a separate field in the log json output. The current approach basically leads to the message field being either a string or an object which always bugged me a bit as it is not a unified format. This would also allow easier extraction for some log collection solutions when storing the log details in elastic search for example.
As it is a breaking change on the format we'd need to properly document that in the changelog.
Any oppinions @ChristophWurst @nickvergessen @MorrisJobke @skjnldsv @kesselb
Before:
After: