Update symfony/event-dispatcher requirement from ~4.4 to ~5.3 in /build/integration#27385
Conversation
Updates the requirements on [symfony/event-dispatcher](https://github.com/symfony/event-dispatcher) to permit the latest version. - [Release notes](https://github.com/symfony/event-dispatcher/releases) - [Changelog](https://github.com/symfony/event-dispatcher/blob/5.3/CHANGELOG.md) - [Commits](symfony/event-dispatcher@v4.4.0...v5.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
|
symfony/event-dispatcher 5.2.1 is being used now by Nextcloud, so it should be fine to use 5.X in the integration tests too. However... the problem back in the day was that Maybe the problem is still there but it is just not triggered due to being a deprecated class and fortunately not used? 🤔 Maybe @ChristophWurst knows what is going on :-) |
|
But 3rdparty is still at 4 that is why i was wondering https://github.com/nextcloud/3rdparty/blob/master/composer.json#L49 |
|
Since the test dependencies should not have any influence on production code I'm fine bumping this if tests pass 🤷 |
|
The import of base.php in the remote tests is still there, that could have caused the 3rdparty dependency loading so no idea why it would now work all of a sudden, but lets get it in then and move on I'd say. |
Updates the requirements on symfony/event-dispatcher to permit the latest version.
Release notes
Sourced from symfony/event-dispatcher's releases.
Changelog
Sourced from symfony/event-dispatcher's changelog.
... (truncated)
Commits
67a5f35Merge branch '5.2' into 5.32ffa4bfMerge branch '4.4' into 5.2047773eFix CS in README filesff708cbAdd#[As-prefix]to service attributes36b7381Deprecate configuring tag names and service ids in compiler passesbcbfcf5feature #40234 [Console] AddConsoleCommandattribute for declaring command...7855ba3Merge branch '5.2' into 5.xd08d6ec[EventDispatcher] fix registering subscribers twice on edge-casea7c8f37[EventDispatcher] add missing "dispatcher" property on #[EventListener]d80457b[Console] AddConsoleCommandattribute for declaring commands on PHP 8Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.github/dependabot.ymlfile in this repo: