set mimetype for objects uploaded to object storages#26575
Merged
Conversation
PVince81
approved these changes
Apr 15, 2021
Member
PVince81
left a comment
There was a problem hiding this comment.
Code looks fine 👍
Assuming you retested all those storages already.
Will the trait method interface change affect/break existing third party implementation ?
Member
Author
Object storages can't be implemented by apps at the moment |
rullzer
approved these changes
Apr 16, 2021
Contributor
|
Tested with minio. Content-Type is now set 👍 |
kesselb
approved these changes
Apr 20, 2021
Signed-off-by: Robin Appelman <robin@icewind.nl>
dcc1fc9 to
effb7dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19487