l10n: Add words user and because in ShareByMailProvider.php#26231
Merged
l10n: Add words user and because in ShareByMailProvider.php#26231
Conversation
Standardizing text strings with other Nextcloud applications.
MorrisJobke
reviewed
Mar 21, 2021
| if (!empty($alreadyShared)) { | ||
| $message = 'Sharing %1$s failed, this item is already shared with %2$s'; | ||
| $message = 'Sharing %1$s failed, because this item is already shared with user %2$s'; | ||
| $message_t = $this->l->t('Sharing %1$s failed, this item is already shared with %2$s', [$share->getNode()->getName(), $shareWith]); |
Member
There was a problem hiding this comment.
Then please also add it here, because that is the string that is translated - the other one is the english one for the debug logs.
Contributor
Author
There was a problem hiding this comment.
An oversight on my part. Thanks 😉.
rullzer
approved these changes
Mar 22, 2021
skjnldsv
approved these changes
Mar 22, 2021
Member
|
/backport to stable21 |
Member
|
/backport to stable20 |
Member
|
/backport to stable19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizing text strings with other Nextcloud applications.