dont show trusted proxy warning when the proxy and remote are both localhost#25605
Merged
dont show trusted proxy warning when the proxy and remote are both localhost#25605
Conversation
…calhost Signed-off-by: Robin Appelman <robin@icewind.nl>
LukasReschke
approved these changes
Mar 30, 2021
Member
LukasReschke
left a comment
There was a problem hiding this comment.
Should be fine. Not a fan of hard-coding stuff but fair :)
rullzer
approved these changes
Apr 1, 2021
Contributor
|
/backport to stable21 |
Contributor
|
/backport to stable20 |
This was referenced Aug 11, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty small edge case, since it requires accessing nextcloud on localhost.
When 127.0.0.1 is setup as a trusted proxy (notify_push wants this as it acts as a proxy for it's auth request) and you're accessing the nextcloud instance from localhost, it triggers the setup warning against insecure trusted proxy setups.
Since localhost should always be trusted, this warning only adds confusion.