Merged
Conversation
nickvergessen
approved these changes
Jan 20, 2021
Add new popover classes from @nextcloud/vue's Popover and PopoverMenu* components. This fixes issues where the menu icons were not inverted. Adjusted border for both the avatar popover menu and also actions popover menu to make them easier to distinguish from the background. Now using border color for the popover arrow to make it more visible outside the border. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
7fd5c84 to
6e2c652
Compare
marcoambrosini
approved these changes
Jan 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new popover classes from @nextcloud/vue's Popover and PopoverMenu*
components. This fixes issues where the menu icons were not inverted.
This fixes the icons are reported in nextcloud/spreed#4976 (review)
Adjusted border for both the avatar popover menu and also actions
popover menu to make them easier to distinguish from the background.
Now using border color for the popover arrow to make it more visible
outside the border.
Required these to produce the screenshots:
Before:
Icons not inverted, border missing and arrow not visible.
After:
Icons correctly inverted, border is back. Arrow more visible.
And actions border menu added.