Use regex when searching on single file shares#24203
Merged
MorrisJobke merged 1 commit intomasterfrom Nov 19, 2020
Merged
Conversation
Member
|
Not a fan of doing this in the |
Member
Author
Let me see. I guess we can. This was just a first attempt to limit the query storm from searches. |
geep33
approved these changes
Nov 18, 2020
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
1a877c8 to
eab4f3d
Compare
Member
Author
Yes I could. |
ChristophWurst
approved these changes
Nov 19, 2020
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 35689: failuremysql8.0-php7.4Show full log |
Member
|
@rullzer Backport to 20? |
Member
Author
sure. I mean shouldn't hurt to much |
Member
Author
|
/backport to stable20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to consult the database when we want to search and
there are a lot of incomming single file shares. We can then just do a
regex and be done with it.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl