Fix nextcloud logo in email notifications misalignment #24135
Fix nextcloud logo in email notifications misalignment #24135rullzer merged 1 commit intonextcloud:masterfrom medical-cloud:fix/23357-nextcloud-logo-in-email-notifications-is-misaligned-in-version-20
Conversation
This comment has been minimized.
This comment has been minimized.
skjnldsv
left a comment
There was a problem hiding this comment.
Other than the other code syntax fix, 👍
Ah right, you need to fix the tests on |
The test have been fixed but the build is still failing. It seems unrelated.
/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1030 Could somebody with more experience have a look (maybe @skjnldsv) ? |
This seems unrelated. Ignore that |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable20 |
Signed-off-by: medcloud 42641918+medcloud@users.noreply.github.com
Fixes the good positionning of theming logo in the circle when sending emails (like share by email or by link) : the logo was on the top of the circle, and circle sometimes on the left aligned in iOS Gmail for instance.
The modification proposed is mainly focused on a square logo which would be correctly centered. However, for a logo like Nextcloud one (252x120px) the display is a bit different but acceptable.
Fix #23357
Fix #23977