#3903 add Background job for cleanup of unneeded remote storages#24095
#3903 add Background job for cleanup of unneeded remote storages#24095european wants to merge 1 commit intonextcloud:masterfrom
Conversation
|
Looks like this PR was overseen because it has no review was requested. |
|
@european I hope you don't mind if i squash your commits into one as the follow up commits are all fixing things in the first one. |
93af317 to
0d2b1ee
Compare
| * @param $argument | ||
| * @return void | ||
| */ | ||
| protected function run($argument) { |
Check notice
Code scanning / Psalm
MissingParamType
0d2b1ee to
9ea3f29
Compare
all fine, I missed this PR as well after that. I was not sure how to continue, since it was my first pr I created for this project |
9ea3f29 to
1868675
Compare
Add a background job for cleanup of unneeded remote storages. Signed-off-by: european <sammellog@gmail.com>
1868675 to
ee33587
Compare
max-nextcloud
left a comment
There was a problem hiding this comment.
Did not test it but code looks fine.
max-nextcloud
left a comment
There was a problem hiding this comment.
Checked in with some colleagues about this pull request.
Instead of triggering the CLI command from the background job the logic should be in a service that is used by both, the Background Job and the CLI command.
That would also avoid using a NullOutput to hide the output.
Background jobs still may need to report errors so hiding the output entirely does not seem like a good idea.
|
@european Sorry it took so long to get back to you in the first place. Would you be willing to pick this up again? I'd be happy to follow up to make sure reviews happen and so on. |
I guess not 😢 @european Thanks for the interest in Nextcloud and the effort put into this! 🙇 |
Signed-off-by: Nils Werner sammellog@gmail.com
This change add a new background job to execute the command CleanupRemoteStorages
See #3903 for more details.
Fixes #3903