Use query builder instead of OC_DB in user_ldap #23933
Merged
MorrisJobke merged 6 commits intomasterfrom Nov 9, 2020
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
blizzz
requested changes
Nov 6, 2020
Member
blizzz
left a comment
There was a problem hiding this comment.
there's an array to string conversion issue on deleting configs
nickvergessen
commented
Nov 6, 2020
ChristophWurst
approved these changes
Nov 6, 2020
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
approved these changes
Nov 6, 2020
Member
|
Mind to add the DB group to the tests in |
Member
|
Lots of ldap issues in the NODB tests |
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 35235: failureintegration-comments-search
Show full logacceptance-users
Show full log |
MorrisJobke
approved these changes
Nov 9, 2020
Member
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested LDAP wizard and provisioning and all still works 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #23929