[stable18] fix display of remote users in incoming share notifications#23549
Merged
nickvergessen merged 1 commit intostable18from Oct 27, 2020
Merged
[stable18] fix display of remote users in incoming share notifications#23549nickvergessen merged 1 commit intostable18from
nickvergessen merged 1 commit intostable18from
Conversation
skjnldsv
approved these changes
Oct 19, 2020
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
95c716d to
5d2537e
Compare
Member
|
@blizzz @nickvergessen I took your changes from #22062 and #22131, removed the CS clutter and combined everything into one commit with only the necessary changes. The code is quite a bit different on stable18 and thus some of the changes didn't apply. Please have a look if all the important pieces are actually there 🙏 |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 34331: failuremariadb10.1-php7.2Show full log |
nickvergessen
approved these changes
Oct 21, 2020
Member
nickvergessen
left a comment
There was a problem hiding this comment.
🐘 looks okay, but didnt execute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backport had conflicts and is incompletebackport of #22062