Annotate IContainer so Psalm knows what resove and query return

[ChristophWurst]

@kesselb IIRC you wanted to add this some time ago. Were there any issues?

• Blocked by Typing a dependency injection container vimeo/psalm#4310 Bump vimeo/psalm from 3.15 to 3.17.1 #23434

[ChristophWurst]

@kesselb IIRC you wanted to add this some time ago. Were there any issues?

🙈

[MorrisJobke]

The encryption app needs to move from those random names to just use the full namespace and then most of this is done.

[MorrisJobke]

Also then most of the encryption app can be auto wired ;)

[ChristophWurst]

The encryption app needs to move from those random names to just use the full namespace and then most of this is done.

While that is true it's still ok to use string that are not a FQCN. Let me see if we can teach Psalm that.

[ChristophWurst]

The last commit will be removed. I'm just testing vimeo/psalm#4310.

[MorrisJobke]

Rebased because other PR was merged.

[MorrisJobke]

Only 4 errors left 🙌

[ChristophWurst]

Only 4 errors left raised_hands

But in other news these are new errors detected because of the typing 🚀

[ChristophWurst]

/backport f9f20b6 to stable20

[MorrisJobke]

@ChristophWurst Ready for review, right?

[ChristophWurst]

Psalm:

Fixed 🙏

[ChristophWurst]

@blizzz hope the logic is unchanged. The search call should always happen no matter the value of $hasMoreResults, right? Asking because there might be semantics of the short-circuit evaluation of an or.

[MorrisJobke]

Ah right ... but yes - the search should happen in every plugin and then it is combined afterwards.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34135: failure

acceptance-users

• tests/acceptance/features/users.feature:103

Show full log

  Scenario: change columns visibility                          # /drone/src/tests/acceptance/features/users.feature:103
    Given I act as Jane                                        # ActorContext::iActAs()
    And I am logged in as the admin                            # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                               # SettingsMenuContext::iOpenTheUserSettings()
    And I open the settings                                    # AppSettingsContext::iOpenTheSettings()
      App settings could not be found
      The button to open the app settings could not be found (NoSuchElementException)
    And I see that the settings are opened                     # AppSettingsContext::iSeeThatTheSettingsAreOpened()
    When I toggle the showLanguages checkbox in the settings   # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
    Then I see that the "Language" column is shown             # UsersSettingsContext::iSeeThatTheColumnIsShown()
    When I toggle the showLastLogin checkbox in the settings   # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
    Then I see that the "Last login" column is shown           # UsersSettingsContext::iSeeThatTheColumnIsShown()
    When I toggle the showStoragePath checkbox in the settings # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
    Then I see that the "Storage location" column is shown     # UsersSettingsContext::iSeeThatTheColumnIsShown()
    When I toggle the showUserBackend checkbox in the settings # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
    Then I see that the "User backend" column is shown         # UsersSettingsContext::iSeeThatTheColumnIsShown()