Fix undefined index and consequential damages in versions code

[ChristophWurst]

If the user has no space and there are no versions, there won't be an
all index in the versions entry. Hence this triggers a warning and
becomes null, afterwards count, foreach and friends will happily
throw even more warnings and errors because they don't want to play with
null. Thus adding a fallback to an empty array.

[ChristophWurst]

/backport to stable20

[ChristophWurst]

/backport to stable19

[kesselb]

Make sense. I also think there are some reports around for this.

[MorrisJobke]

@ChristophWurst I added a commit that added the changes the @nickvergessen proposed, because I think that is the better approach to deal with this.

[nickvergessen]

DB tests are not happy. Seems to be the "random fail" but it failed on all DBs here, so not sure its unrelated?

[ChristophWurst]

DB tests are not happy. Seems to be the "random fail" but it failed on all DBs here, so not sure its unrelated?

Unfortunately also happening with other PRs right now

[MorrisJobke]

DB tests are not happy. Seems to be the "random fail" but it failed on all DBs here, so not sure its unrelated?

Fixed with #23391

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34039: failure

sqlite

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:729

mysql8.0-php7.4

• I'm a little sad 🤖 and was not able to find the logs for this failed job - please improve me at https://github.com/MorrisJobke/drone-logs to provide this to you