Fix numeric folders throwing on markDirty#23034
Merged
nickvergessen merged 1 commit intomasterfrom Sep 25, 2020
Merged
Conversation
TypeError: strpos() expects parameter 1 to be string, int given The problem is that in cacheNode() we strip of any slashes, so a folder "0/" will be trimmed to "0" and be used as an array key. Since PHP automatically casts numeric array keys to integers, you afterwards get $nodePath as int(0). Since it's now a number, the strpos() function does not accept it anymore. Simply casting $nodePath to a string again in the foreach solves the issue Signed-off-by: Joas Schilling <coding@schilljs.com>
rullzer
approved these changes
Sep 24, 2020
icewind1991
approved these changes
Sep 25, 2020
Member
Author
|
Backport I guess? |
Member
|
/backport to stable20 |
Member
|
/backport to stable19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeError: strpos() expects parameter 1 to be string, int given
The problem is that in cacheNode() we strip of any slashes, so
a folder
0/will be trimmed to'0'and be used as an array key.Since PHP automatically casts numeric array keys to integers,
you afterwards get $nodePath as int(0). Since it's now a number,
the strpos() function does not accept it anymore. Simply casting
$nodePath to a string again in the foreach solves the issue