Mitigate encoding issue with user principal uri#22770
Merged
Conversation
Member
Author
|
@MorrisJobke @rullzer I would appreciate if we could backport this |
e91618a to
fcddf8b
Compare
Member
Author
Fixed a typo in the comment |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32951: failureacceptance-access-levels
Show full logacceptance-app-files
Show full logacceptance-app-files-sharing
Show full logacceptance-app-files-sharing-link
Show full logacceptance-app-files-tags
Show full logacceptance-app-theming
Show full logacceptance-header
Show full logacceptance-login
Show full logacceptance-users
Show full logacceptance-apps
Show full log |
Signed-off-by: Georg Ehrke <[email protected]>
fcddf8b to
b5204a7
Compare
skjnldsv
approved these changes
Sep 14, 2020
Member
|
/backport to stable19 |
Member
|
/backport to stable18 |
Member
|
/backport to stable17 |
This was referenced Sep 14, 2020
csware
reviewed
Oct 12, 2020
| $user = $this->userManager->get($name); | ||
| // Depending on where it is called, it may happen that this function | ||
| // is called either with a urlencoded version of the name or with a non-urlencoded one. | ||
| // The urldecode function replaces %## and +, both of which are forbidden in usernames. |
Contributor
There was a problem hiding this comment.
This assumption is not correct. For historic reasons there still are usernames containing "+".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test this:
Master:
This branch:
Disclaimer:
The problem is bigger than this and requires a better fix in the long run. It is necessary, to have consistent, url-encoded principal uris everywhere.