Register services early in case they might already be queried though other registrations#22727
Register services early in case they might already be queried though other registrations#22727juliusknorr wants to merge 1 commit intomasterfrom
Conversation
…the other registations Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
🤔 where is that a problem? Shouldn't the registration part be as lazy as possible? Like in a sense that nothing really is executed yet. |
Ideally yes, just found this when debugging nextcloud/deck#2275 and thought it might be a good hardening to avoid possible issues in case app developers don't properly handle lazy registration like myself ;) |
🙈 so I would not see this as a hardening step. The premise of of the register and boot separation is to not have any assumptions about what's there in the early call of register. |
ChristophWurst
left a comment
There was a problem hiding this comment.
👎 as of #22727 (comment) :)
|
Ok, let's close then 👍 |
Otherwise services might not be resolved since they are registered too late