[stable17] Fix PHPUnit deprecation warnings #22059
Closed
backportbot-nextcloud[bot] wants to merge 5 commits intostable17from
Closed
[stable17] Fix PHPUnit deprecation warnings #22059backportbot-nextcloud[bot] wants to merge 5 commits intostable17from
backportbot-nextcloud[bot] wants to merge 5 commits intostable17from
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Morris Jobke <[email protected]>
See sebastianbergmann/phpunit#3339 (comment) It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls. Signed-off-by: Morris Jobke <[email protected]>
…ameter Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
…ls in constructor tests I removed the tests completely because they just test that the constructor assigns the values to the internal properties. Nothing that should be cared about from the outside. See sebastianbergmann/phpunit#3339 (comment) It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls. Signed-off-by: Morris Jobke <[email protected]>
cadae82 to
ffcb283
Compare
MorrisJobke
approved these changes
Jul 30, 2020
Member
I just cherry-picked manually and fixed one conflict (due to whitespace foo). Looks good now 👍 |
nickvergessen
approved these changes
Jul 30, 2020
Member
|
17 is still on PHPUnit 6.5 -> closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #22058