[stable19] Respect default share permissions

[backportbot-nextcloud]

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #21963

[rullzer]

/compile amend /

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31010: failure

mariadb10.4-php7.3

Show full log

There were 8 warnings:

1) Test\DB\DBSchemaTest::testSchema
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

2) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "all" (array(0, 1, 2, 3), array(), array())
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.

3) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "only-todos" (array(), array('VTODO'), array())
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.

4) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "only-events" (array(0, 1, 2, 3), array(), array(array('VEVENT', false, array(), array(null, null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.

5) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "start" (array(1, 2, 3), array(), array(array('VEVENT', false, array(), array(DateTime Object (...), null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.

6) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "end" (array(0), array(), array(array('VEVENT', false, array(), array(null, DateTime Object (...)), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.

7) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "future" (array(3), array(), array(array('VEVENT', false, array(), array(DateTime Object (...), null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.

8) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testCreate
assertArraySubset() is deprecated and will be removed in PHPUnit 9.

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGroupDeleted with data set #1 (array(0, 'user', array()), 'user', false)
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:2435

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

/drone/src/apps/twofactor_backupcodes/tests/Db/BackupCodeMapperTest.php:115

[MorrisJobke]

/compile /

[liejuntao001]

Could this be backported to stable 18? I see this problem in 18.0.11

[MorrisJobke]

Could this be backported to stable 18? I see this problem in 18.0.11

It is already: #24437