Closed
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
commented
Jul 14, 2020
| * @param array $entry | ||
| * @depreacted 20.0.0 Use \OCP\Authentication\Events\AlternativeLoginOptionsEvent | ||
| */ | ||
| public static function registerLogIn(array $entry) { |
Member
Author
There was a problem hiding this comment.
I'm also fine with dropping this immediately.
I guess apart from the registration app some apps from https://apps.nextcloud.com/?search=login might need adjustment
2 tasks
ChristophWurst
approved these changes
Jul 14, 2020
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
Not a fan of mutable events but 🐘
Member
|
Let me try something in another PR that helps move things like this to registration but still make it kind of lazy. |
Member
Author
|
Replaced by #21850 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling coding@schilljs.com