Skip to content

Bye bye database xml#21641

Merged
rullzer merged 2 commits intomasterfrom
techdebt/noid/bye-bye-database-xml
Mar 25, 2021
Merged

Bye bye database xml#21641
rullzer merged 2 commits intomasterfrom
techdebt/noid/bye-bye-database-xml

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 30, 2020 •
edited
Loading

@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Jun 30, 2020
@nickvergessen nickvergessen force-pushed the techdebt/noid/bye-bye-database-xml branch from 6be4bc3 to 569975e Compare July 1, 2020 06:26
nickvergessen
nickvergessen commented Jul 1, 2020
View reviewed changes
@nickvergessen nickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 2, 2020
MorrisJobke
MorrisJobke approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

This was referenced Jul 6, 2020
Merged
Closed
@nickvergessen nickvergessen force-pushed the techdebt/noid/bye-bye-database-xml branch from 87c6d9e to 2316080 Compare July 7, 2020 17:21
@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
Merged
57 tasks
@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 13, 2020

Something for 21

@rullzer rullzer mentioned this pull request Dec 14, 2020
Merged
59 tasks
@nickvergessen
Copy link
Member Author

nickvergessen commented Dec 14, 2020

Should merge/redo after 21 is branched off.

@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Dec 14, 2020
@ChristophWurst ChristophWurst mentioned this pull request Dec 14, 2020
Merged
@PVince81
Copy link
Member

PVince81 commented Mar 17, 2021

a wild group of conflicts appeared

@nickvergessen
Copy link
Member Author

nickvergessen commented Mar 24, 2021

yeah, anyone can feel free to take over and re do it.
I'm currently lacking the time to do so

@MorrisJobke MorrisJobke self-assigned this Mar 24, 2021
@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 24, 2021

The first two commits are already handled by #24247. Let me continue there.

@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 24, 2021

b156cf8 is handled in #24035

@MorrisJobke MorrisJobke mentioned this pull request Mar 24, 2021
Closed
@MorrisJobke MorrisJobke force-pushed the techdebt/noid/bye-bye-database-xml branch from 2316080 to 4851efd Compare March 24, 2021 19:02
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 24, 2021
@nickvergessen @MorrisJobke
Bye bye database.xml
bb0c507 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke MorrisJobke force-pushed the techdebt/noid/bye-bye-database-xml branch from 4851efd to bb0c507 Compare March 24, 2021 19:04
@MorrisJobke MorrisJobke mentioned this pull request Mar 24, 2021
Open
@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 24, 2021

I just cleaned up a bit behind the removal of the usage of database.xml and removed all the helper classes (and their tests). 🧹

@MorrisJobke MorrisJobke force-pushed the techdebt/noid/bye-bye-database-xml branch from 25316f1 to 6b9a765 Compare March 24, 2021 20:45
@MorrisJobke
Cleanup unneeded code around database.xml
ab48d5e 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the techdebt/noid/bye-bye-database-xml branch from 6b9a765 to ab48d5e Compare March 24, 2021 21:15
MorrisJobke
MorrisJobke approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side 🚀

rullzer
rullzer approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@rullzer rullzer merged commit c15172b into master Mar 25, 2021
@rullzer rullzer deleted the techdebt/noid/bye-bye-database-xml branch March 25, 2021 07:58
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gary-kim gary-kim gary-kim left review comments

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@MorrisJobke MorrisJobke

Labels

3. to review Waiting for reviews feature: install and update technical debt

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @MorrisJobke @PVince81 @rullzer @ChristophWurst @gary-kim