Only catch anonymous OPTIONS for Office#20632
Merged
MorrisJobke merged 1 commit intomasterfrom Apr 27, 2020
Merged
Conversation
georgehrke
approved these changes
Apr 24, 2020
Member
georgehrke
left a comment
There was a problem hiding this comment.
Nextcloud returns a proper 401 instead of 404 for OPTIONS /remote.php/dav/principals/users/georg.
👍
Don't have a Windows machine to test the implications on Office though
Member
|
/backport to stable18 |
Member
|
/backport to stable17 |
Member
Author
|
At least when checking the access logs we had for #16739 it should still be fine with checking the user agent against |
18d7ecf to
47bd4a0
Compare
MorrisJobke
reviewed
Apr 24, 2020
MorrisJobke
reviewed
Apr 24, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
91a403b to
d7161b4
Compare
MorrisJobke
approved these changes
Apr 27, 2020
|
backport to stable18 in #20680 |
|
backport to stable17 in #20681 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should do the trick and still work for the original issue with opening office files in subdirectories when mounting the WebDAV endpoint in Windows, but I cannot test that as I don't have a Windows/Office installation.
For #20624