Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv
approved these changes
Jan 8, 2020
Member
|
master is NC19 now. |
Member
|
Might be related Scenario: just added users are seen in the contacts menu # /drone/src/tests/acceptance/features/header.feature:31
111 | Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
112 | And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
113 | And I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
114 | New user button in Users Settings could not be found (NoSuchElementException)
115 | And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
116 | And I create user user1 with password 123456acb # UsersSettingsContext::iCreateUserWithPassword()
117 | And I see that the list of users contains the user user1 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
118 | When I open the Contacts menu # ContactsMenuContext::iOpenTheContactsMenu()
119 | Then I see that the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
120 | And I see that the contact "user0" in the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
121 | And I see that the contact "user1" in the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
122 | And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown() |
Member
Author
|
As far as I understand it the failure is here: 112 | And I open the User settings # SettingsMenuContext::iOpenTheUserSettings() Doesn't seem related to me. Triggered a new run to be sure |
Member
|
Yep seems fine. |
Member
|
/backport to stable18 |
|
backport to stable18 in #18797 |
Member
|
Ah mmmmm. seems this breaks the SCSS tests... @juliushaertl or @skjnldsv do you have a clue? |
Member
Author
|
Hm aparently min is not well supported yet, let me see what we can do as an alternative. |
Member
Author
|
#18806 for reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @nickvergessen