Skip to content

A pending shares overview#18707

Merged
rullzer merged 2 commits intomasterfrom
enh/pending_shares_overview
Jan 7, 2020
Merged

A pending shares overview#18707
rullzer merged 2 commits intomasterfrom
enh/pending_shares_overview

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Jan 7, 2020

Now that we accept shares we should show an overview of shares that are
pending. This first part is the small API to get a list of the currently
pending shares.

As noticed by @tobiasKaminsky
If you now press X on a share. It just doesn't show.

For now I would go for a new section in the sharing section. But for 19 we should look into unifying this with the deleted shares. @nextcloud/designers

@rullzer
A pending shares overview
fbed6a3 
Now that we accept shares we should show an overview of shares that are
pending. This first part is the small API to get a list of the currently
pending shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added this to the Nextcloud 18 milestone Jan 7, 2020
@juliusknorr
Copy link
Member

juliusknorr commented Jan 7, 2020

@rullzer Pushed a commit for the frontend part. For now I've added a separate "pending shares" list where the user can either accept or reject them.

@rullzer
Copy link
Member Author

rullzer commented Jan 7, 2020

@juliushaertl mmm it isn't working for me... I don't see the request in the network tab as well..

@juliusknorr juliusknorr force-pushed the enh/pending_shares_overview branch from 1db494a to 87ea79a Compare January 7, 2020 12:15
@rullzer
Copy link
Member Author

rullzer commented Jan 7, 2020

Awesome!

Only thing. The details and show in folder in the '...' are kind of broken now...

@juliusknorr juliusknorr force-pushed the enh/pending_shares_overview branch from 87ea79a to a3a510c Compare January 7, 2020 12:32
@juliusknorr
Copy link
Member

juliusknorr commented Jan 7, 2020

Only thing. The details and show in folder in the '...' are kind of broken now...

Fixed 😉

@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 7, 2020
@wiswedel
Copy link
Contributor

wiswedel commented Jan 7, 2020

@juliushaertl Can you provide a screenshot please?

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jan 7, 2020

image

Behind "Name" is 123.txt, which is barely readable.

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jan 7, 2020

(might be because of my test system, but I did not got any notification (red alarm bell)?
I thought I received one on plain master?

@juliusknorr
Copy link
Member

juliusknorr commented Jan 7, 2020

Behind "Name" is 123.txt, which is barely readable.

Unrelated, please open a separate issue.

(might be because of my test system, but I did not got any notification (red alarm bell)? I thought I received one on plain master?

Do you have the notifications app enabled and did you wait for some time as the web ui just polls regularly for new notifications.

@rullzer
Copy link
Member Author

rullzer commented Jan 7, 2020

(might be because of my test system, but I did not got any notification (red alarm bell)?
I thought I received one on plain master?

This doesn't touch any notification code.
So lets review what this fixes and get it in and then we look at other things ;)

@rullzer rullzer mentioned this pull request Jan 7, 2020
Merged
1 task
@tobiasKaminsky tobiasKaminsky mentioned this pull request Jan 7, 2020
Closed
@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jan 7, 2020

👍 working otherwise

@jancborchardt
Copy link
Member

jancborchardt commented Jan 7, 2020

For now I would go for a new section in the sharing section. But for 19 we should look into unifying this with the deleted shares. @nextcloud/designers

:( I heard this often before … yes I guess it has to be done like this for lack of time, but I’m not happy as I doubt it will in fact be fixed for 19. The spec has been there for ages at #2192

@juliusknorr
Copy link
Member

juliusknorr commented Jan 7, 2020

:( I heard this often before … yes I guess it has to be done like this for lack of time, but I’m not happy as I doubt it will in fact be fixed for 19. The spec has been there for ages at #2192

If we schedule some time for that in 19, I think this should be doable with not to much effort. Just nothing we can implement properly 1 1/2 weeks before the actual release.

@rullzer
Copy link
Member Author

rullzer commented Jan 7, 2020

For now I would go for a new section in the sharing section. But for 19 we should look into unifying this with the deleted shares. @nextcloud/designers

:( I heard this often before … yes I guess it has to be done like this for lack of time, but I’m not happy as I doubt it will in fact be fixed for 19. The spec has been there for ages at #2192

I know what you mean. But the alternative is that we have nothing right now. ;)

@juliusknorr @rullzer
Add pending share list to frontend
445274c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the enh/pending_shares_overview branch from a3a510c to 445274c Compare January 7, 2020 18:36
@rullzer
Copy link
Member Author

rullzer commented Jan 7, 2020

Fixed the tests.
Lets do this.

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 7, 2020
@rullzer rullzer merged commit 4d1f710 into master Jan 7, 2020
@rullzer rullzer deleted the enh/pending_shares_overview branch January 7, 2020 19:55
john6361
john6361 approved these changes May 14, 2025
View reviewed changes
Copy link

@john6361 john6361 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@kesselb kesselb Awaiting requested review from kesselb

@gary-kim gary-kim Awaiting requested review from gary-kim

@wiswedel wiswedel Awaiting requested review from wiswedel

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

1 more reviewer

@john6361 john6361 john6361 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: sharing

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@rullzer @juliusknorr @wiswedel @tobiasKaminsky @jancborchardt @john6361