Clarify "Delete share" action in sharing sidebar#18563
Clarify "Delete share" action in sharing sidebar#18563skjnldsv merged 3 commits intonextcloud:masterfrom alexandregv:patch-1
Conversation
- change "Delete share" to "Unshare" - change icon-delete to icon-close Signed-off-by: Alexandre Guiot--Valentin <contact@alexandregv.fr>
|
/compile amend / EDIT: Welp, this isn't working. I'll just do it myself. |
Signed-off-by: Alexandre Guiot--Valentin <contact@alexandregv.fr> Signed-off-by: Gary Kim <gary@garykim.dev>
gary-kim
left a comment
There was a problem hiding this comment.
Thank you for your contribution and welcome!
|
No problem 🙂 Thanks ! |
|
Hi @alexandregv! Thanks a lot! I think they were forgotten :) |
|
/compile amend / Ah right, it doesn't work on forks. |
|
Oh, that's why it didn't work! |
Signed-off-by: Alexandre Guiot--Valentin <contact@alexandregv.fr> Signed-off-by: Gary Kim <gary@garykim.dev>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
jancborchardt
left a comment
There was a problem hiding this comment.
Only saw it now, thanks a lot for fixing this detail @alexandregv – and welcome to Nextcloud! :)
As requested in #18477 (originally #18202), this PR:
Fixes: #18477
Signed-off-by: Alexandre Guiot--Valentin contact@alexandregv.fr