Conversation
8a4f14e to
9f3df9a
Compare
kesselb
approved these changes
Dec 20, 2019
Signed-off-by: Joas Schilling <coding@schilljs.com>
9f3df9a to
e37af2d
Compare
Contributor
|
I still wonder where the |
Contributor
server/lib/private/Avatar/UserAvatar.php Line 104 in 5bf3d1b Found it. It's probably safe to remove the other remove statement with the try-catch around. But there is no lock for the folder so another process could create a new generated avatar in the meantime. I don't know ;) |
Member
Author
|
Yeah I gues that is exactly the issue. |
rullzer
approved these changes
Dec 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #18481