Do not generate tokens for editor IDs that do not exist#18478
Merged
Do not generate tokens for editor IDs that do not exist#18478
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
juliusknorr
approved these changes
Dec 20, 2019
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Member
|
Pushed another small commit to actually show the exception message. |
Member
|
Steps to test:
|
Contributor
We are not leaking any information with that? |
kesselb
approved these changes
Dec 20, 2019
Member
I doubt so. You can get the list of available editorIds via another endpoint. |
Contributor
Thanks 👍 I restarted the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18240
Untested as I have no clue how to use this :D